simultaneous hit collision bug problem P1 & enemy

[DEMONKAI]

Iva had this issue for a hot while now and ive been trying to find ways to deal with it bug but no dice...

Its an elusive bug that happens just as the enemy is hitting my character as hes hitting them with the power tackle takedown move. MY character staggers back but the enemy is stunned completely in a lie down state. I read by chance Pots speaking on this same kind of bug and it was for regular throws. i assumed this would work for my move since technically it is a throw move also.

The bug highly happens versus pots vega since he seems to always make this happen

Anway Heres the code he posted to solve such an issue

(I really dont have a strategy right now on how i can use that maybe. IF i can)
[State 800, Hit]
type=hitdef
(...)
p1stateno= 810

[State 810, Throw]
type= targetstate
trigger1= !time && numtarget
value= 815



heres my code here:



FIRST PART (initial run)

(click to show/hide)

[Statedef 7006]
type    = S
movetype= A
physics = S
anim = 9901
poweradd=-500
ctrl = 0
velset = 0,0
juggle = 4
facep2 = 1

[State -2, ExShadow]
type=afterimage
triggerall = var(20)<=0
trigger1 =animelem = 1
time=20
timegap=1
framegap=2
length=15
palbright=32,32,0
palcontrast=128,128,128
paladd=-10,-10,-10
palmul=1.1,1,.5
palfx.time=32
trans=add
ignorehitpause=1

[State 810, HitBy]
type = NotHitBy
trigger1 = AnimElemTime(5) < 0
value = SCA


[State 0, Width]
type = Width
trigger1 = 1
edge = 75,0

[State 6025, dash]
type = Explod
trigger1 = animelem = 3
anim = 6604
pos = -15,2
postype = p1
ownpal = 1
ontop = 1
scale = .5,.5
bindtime = 1
removeongethit = 1
removetime = 15
supermove = 255
ID = 6604
sprpriority = 9

[State 0, RemoveExplod]
type = RemoveExplod
trigger1 = time = 0
id = 6192

[State 0, PlaySnd]
type = PlaySnd
trigger1 = animelem = 1
trigger1 =(random%3)
value = S80,11
channel = 1
persistent = 1

[State 0, PlaySnd]
type = PlaySnd
trigger1 = animelem = 1
trigger1 =(random%3)
value = S80,103
channel = 1
persistent = 1

[State 0, PlaySnd]
type = PlaySnd
trigger1 =(random%3)
trigger1 = Animelem = 1
value = S80,148
channel = 1
persistent = 1

[State 1000, 1]
type = PlaySnd
trigger1 = animelem = 2
value = 10,4
channel = 2

[State 3000, carga]
type=helper
trigger1=time = 0
helpertype=normal
stateno=22501
ID=22501
name="Fx"
postype=p1
pos = 12,-60
ownpal=1
persistent=0
supermovetime=9999
ignorehitpause = 1
size.xscale =1
size.yscale =1

[State 1022, VelSet]
type = VelSet
trigger1 = animelem = 2
x = 25

[State 1022, VelSet]
type = VelSet
trigger1 = animelem = 7
x = 0

[State 0, VelMul]
type = Velmul
trigger1 = AnimElemtime(7) >= 1
x = .88

[State 10957]
type = Veladd
trigger1 = animelemtime(2) >= 0 && animelemtime(7) < 0
x = -.1

[State 1000, 6]
type = ChangeState
trigger1 = P2BodyDist X <= 56
value = 7008
ctrl = 0

[State 1000, 6]
type = ChangeState
trigger1 = time = 32 && !var(24)
trigger2 = time = 47 && var(24)
value = 7007
ctrl = 0

SECOND PART (state if he misses)

(click to show/hide)

[Statedef 7007]
type    = S
movetype= A
physics = N
poweradd= 0
ctrl = 0
velset = 0
sprpriority = 2

[State 1000, ChangeAnim]
type = ChangeAnim
trigger1 = !time
value = 1137

[State 1031, PlaySnd]
type = PlaySnd
trigger1 = time = 1
value = S90,10
volume = 255
channel = 1
ignorehitpause = 1
persistent = 1

[State 0, PlaySnd]
type = PlaySnd
trigger1 = Animelem = 6
value = S50,1
value = 255
channel =2


[State -2, Accel]
type = VelSet
trigger1 = animelem = 1
x = 15.373046875

[State -2, Accel]
type = VelSet
trigger1 = animelem = 1, > 0
x = (5.5575103759765625*exp((-0.21245725851142667212614710105998)*(time-1)))

[State 1000, 6]
type = ChangeState
trigger1 = !animtime
value = 0
ctrl = 1

3RD PART (state for hit def of take down)

(click to show/hide)

[Statedef 7008]
type    = S
movetype= A
physics = S
poweradd= 10
ctrl = 0
velset = 0
sprpriority = 2



[State 1000, ChangeAnim]
type = ChangeAnim
trigger1 = !time
value = 1124

[State 1000, Spark]
type = Explod
trigger1 = AnimElem = 5
anim = 6186
pos = 35,-5
scale = .5,.5
postype = p1
facing = 1
ownpal = 1
sprpriority = 3
supermovetime = -1
scale = .6,.6


[State 1031, PlaySnd]
type = PlaySnd
trigger1 = time = 1
value = S90,10
volume = 255
channel = 2
ignorehitpause = 1
persistent = 1

[State 0, PlaySnd]
type = PlaySnd
trigger1 =(random%3)
trigger1 = Animelem = 8
value = S80,115
channel = 3

[State 0, PlaySnd]
type = PlaySnd
trigger1 =(random%3)
trigger1 = Animelem = 8
value = S80,121
channel = 3



[State 0, PlaySnd]
type = PlaySnd
trigger1 = Animelem = 1
value = S10,0
value = 255
channel = 4

[State 0, PlaySnd]
type = PlaySnd
trigger1 = Animelem = 6
value = S50,1
value = 255
channel = 5

[State -2, Accel]
type = VelSet
trigger1 = animelem = 1
x = 8.5

[State -2, Accel]
type = VelSet
trigger1 = animelem = 3
x = 13.46875

[State -2, Accel]
type = VelSet
trigger1 = animelem = 3, > 0
x = (7.470703125*exp((-0.064538521137571171672923915683993)*(time-6)))

[State 7008, 1]
type = HitDef
trigger1 = !time
attr =A, SA
damage = 0
animtype = Hard
guardflag = MA
hitflag = MAF
priority = 4, Hit
pausetime= ifelse(var(20),0,0), ifelse(var(20),0,0)
sparkNo = -1 + 0 * (var(33) := 225064)
guard.sparkNo = -1 + 0 * (var(34) := 225063)
sparkxy = -10 + 0*(var(35):=85), var(36):=-47
ground.type = Low
air.type = Low
ground.slidetime = 17
ground.hittime  = 17
ground.velocity = 0
guard.pausetime  = 2,2
guard.slidetime = 17
guard.hittime = 17
guard.ctrltime = 19
air.type = High
air.velocity = 0
air.hittime = 13
air.juggle = 8
getpower = 0,0
givepower = 16,16
snap = 25,0
p1stateno = 7009
p2stateno = 7011
p2facing = 1
id = 7006
forcestand = 1
ground.cornerpush.veloff = 0
guard.cornerpush.veloff = -0
air.cornerpush.veloff = 0
yaccel = .5


[State 1022, ChangeState]
type = ChangeState
triggerall = animelemtime(2) > 0
trigger1 = movehit
value = 7009
ignorehitpause = 0

[State 1000, 6]
type = ChangeState
trigger1 = !animtime
value = 0
ctrl = 1

(Btw this an old code i used as a base to build from that was in a KOF Ralf i had since i wanted the same kind of attack)

currently i will be chipping at the issue while i wait on a reply


EDIT:

I think i fixed it. its not happening anymore.

solution?:

Well i read a lil further down in pots thread and saw Cyanide post this "Although target state is far better, priority = 4,miss in the hitdef itself would also prevent that"

I got curious and added that in my hit def and it seemed to kill the bug....i hope it did at least. I kept making my character clash with vega with that move the instant he attacked and it wasnt happening anymore so maybe that did it

Well if anyone still wants to post opinions on solutions please do so. Im all ears on stuff i can learn. just in case the bug shows up again i dont mind having alternate solutions. Ill keep testing him against that Vega to see what turns up in a good half HR^^

[Cyanide]

Aside from miss which you've added.

It's always good to have an "out" in custom get hits using selfstate. For example if you KNOW your character will do something else within a second but the character is still in a specific custom state beyond that point, have them leave it. Taking your example. Character doesn't sound like they are targetbound. So you do

[State Selfstate]
type = selfstate
trigger1 = time > 60
value = 5120
ctrl = 0

Sending them back to getup after they have been lying down for 60 ticks. You should always provide some sort of "out" for your opponent to prevent bugs.

Also this is bad
pausetime= ifelse(var(20),0,0), ifelse(var(20),0,0)

That does nothing whatsoever.

[DEMONKAI]

Good stuff here. thanks for the tip. yeah im looking the code over again a bit. but overall the bug stopped happening since i put that "miss" in there

[Cyanide]

Best to do it regardless of whether it's fixed or whether the attack worked. You never know when something else might happen. For example, you hit p2 but a helper hits you. That would have the same effect.

[DEMONKAI]

I agree with you. i put that code in there before i went to bed last night...well to be more clear on what i did i rather show you...just let me know if that was a good place to put it....I assumed this is where its supposed to be

(click to show/hide)

This is the last part of the entire move

[Statedef 7013]
type = L
movetype = H
physics = N
ctrl = 0

[State 3053, ChangeAnim]
type = ChangeAnim
trigger1 = time < 47
trigger1 = !SelfAnimExist(5161)
value =5080

[State 3053, ChangeAnim]
type = ChangeAnim
trigger1 = SelfAnimExist(5101)
trigger1 = SelfAnimExist(5161)
trigger1 = Time < 50
value = 5080


[State 3053, ChangeAnim]
type = ChangeAnim
trigger1 = Time = 47;51
trigger1 = anim = 5101
value = 5101

[State -2, Accel]
type = VelSet
trigger1 = time > 2 && time < 47
x = -(11.921875*exp((-0.16068238169047346554330839799803)*(time)))

[State -2, Accel]
type = VelSet
trigger1 = time = 47
x = 0

[State 3050, NotHitBy]
type = NotHitBy
trigger1 = 1
value = SCA
time = 1

[State Selfstate]<---THE NEW CODE
type = selfstate
trigger1 = time > 60
value = 5120
ctrl = 0

;[State 3053, SelfState]<---------OLD CODE I HAD THERE
;type = SelfState
;trigger1 = Time = 47;
;value = 5110

Nothing bad or weird happened after i did that. code seemed to fit fine there^^

EDIT:

Nevermind. something bad did happen when i added that there. i noticed it when i killed my own character with the move. i was testing it on other characters and didnt see it. when he died he got back up again. eh thats fine, i changed it back but ill wait to see what you say on where that should have been placed. sometimes i fix and break codes i made at the same time forgetting what i did before.

[Cyanide]

I gave you an example, not a copy-pasta...

There was nothing wrong with the old selfstate. Put it back and delete what you copied in.

Not that the state you've posted doesn't have issues. Shall we try fixing those?

[State 3053, ChangeAnim]
type = ChangeAnim
trigger1 = time < 47
trigger1 = !SelfAnimExist(5161)
value =5080

Time less than 47 and anim 5161 doesn't exist, go to anim 5080. No problems there. That's fine

[State 3053, ChangeAnim]
type = ChangeAnim
trigger1 = SelfAnimExist(5101)
trigger1 = SelfAnimExist(5161)
trigger1 = Time < 50
value = 5080

Time less than 50, so same as above basically, and if both those anims DO exist, go to animation 5080, so, the same as the code above except instead of "do this if this isn't there" it's saying "do this if that thing that wasn't there is, btw it's the same thing you did before"

[State 3053, ChangeAnim]
type = ChangeAnim
trigger1 = Time = 47;51
trigger1 = anim = 5101
value = 5101

Then we have this, which does nothing. If time = 47 (when we're leaving the state) go to anim 5101 but only if we're already in anim 5101.

All your code looks at anim 5080. It may as well simply be

[State 3053, ChangeAnim]
type = ChangeAnim
trigger1 = time < 47
value =5080

And leave the rest out. I can see how you're getting snarled up if you just leave old code in place and never clean it out. I mean, none of this will BREAK anything, but none of it is truly doing anything so it doesn't need to even be there.

[DEMONKAI]

Got you. totally understand. yeah that code as i said was from another character Ralph KOF and it worked as is so i didnt want to complicate things more at the time by taking chances and removing it since its serving its purpose sorta for the similar attack i wanted.

But anyway now that you have confirmed its fine to remove it ill listen,simplify the code and get the rest out of there.

Thanks for the clear breakdown of that.

[Sabaki]

This is a problem I've seen for the longest and struggled to resolve with different tricks myself. Lately I've been successful, similar to how Cyanide explained it. Two points that should be taken into account are 1) getting your player to stop the throw sequence if the opponent isn't in the target state, and 2) making the opponent to get out of the target state in case your character isn't in the throw state (or, the state that puts the opponent into the target state) anymore.

Looking at the 1st point, you can use a time to have your character quickly get back into, let's say stateno = 0 & ctrl = 1 so not to break up the flow of the fight. Using your example, let's say that in stateno 800, we use the same hitdef, but also add a p2stateno for the opponent.

[State 800, Hit]
type=hitdef
(...)
p1stateno= 805
p2stateno = 810

Now, let's say that under normal conditions, when this move connects, your character goes into stateno 805 & completes the full attack/throw animation from there. However, when you are attacked by the opponent while in state 800 and both hit at the same time, the opponent does not go into stateno = 810 (but goes into a regular gethit state, such as 5000, 5010, etc), yet you proceed to state 805. You can add this to state 805:

[State 805, State Cancel]
type = ChangeState
trigger1 = Time >= 5 && p2stateno != 810
value = 0
ctrl = 1

The time can be changed to any value you like, but preferably it should not be smaller than 5 imho. Also, you can change trigger1 to this:

trigger1 = Time >= 5 && p2stateno = [5000,5110]

While this too works, it should be relation to how your character's move works and doesn't accidentally interrupt the move if it successfully connects. This cancel changestate can be used even for moves that have multiple states, so if your character goes into another sequence for the move in stateno = 806, you can still add this cancel changestate in state 805, as well as 806 (if necessary).

Now for point 2, pretty similar to what's written above, but most importantly you have to use a selfstate and not a changestate; if you use the latter then the opponent will not be able to attack until hit. So, in state 810, you can add something like this:

[State 810, SelfState]
type = SelfState
trigger1 = time > 5 && enemynear, movetype = H (enemynear is your character)
value = 0
ctrl = 1

Have the opponent go into the correct stateno based on whether he/she is on the ground, in the air, etc. You can be creative and experiment with other tricks, but be sure that they match the situation and don't "break " either characters.

Oh, and in regards to that point where you said your character died but got back up, if characters are put into a custom state that can kill them, it's best to have a failsafe and use coding that have them go to, say state 5110 if they are still alive, or state 5150 if their life = 0 during the custom state. You can write this with 2 changestates (selfstates for the opponent), 1 changestate/selfstate with a ifelse to switch between the appropriate stateno, etc.

Just my two cents.

[DEMONKAI]

Thanks on your breakdown as well. issue is fine now since what cyanide posted but reading through this also was good for me to know for new projects. that bug was elusive as hell^^

[Sabaki]

Np  . Figured it's been resolved, but when I read your 1st post it brought back (head-banging & painstaking) memories when I would encounter this situations myself. Just felt like sharing some of the points I came across to deal with this.

[DEMONKAI]

And its well appreciated man  annoying situation i had for a hot while. got tired of seeing it happen

Its tricky for me at times to spot bugs because it may happen in one character but wont in another. isolated bugs that are elusive are the worst