Help/Advice With Coding Questions for W.I.P.s

[Playing Enemy]

And don't forget, trial and error also is a key thing of learning. Challenge yourself. If you ever took apart toys as a kid and put em back together again then youll know exactly where I'm coming from

I know what you mean and totally agree with you too. I love messing around with stuff to understand how it works. Me having to figure things out in the past has led to learning about all sorts of cool new stuff I never would've known about otherwise.

On another note, I have a new issue that I was hoping to get some help with if possible. I've converted a character to Winmugen, and he is running fine, except his AI automatically takes over. I've managed to locate the cause for the most part, but not sure exactly. If I just remove the whole thing, he runs without automatic AI, but has some odd graphical issues, but if I leave it, he has auto AI. I was just curious if someone could pinpoint the line/s of code that is actually causing the AI to take over, so that I could then attempt to properly remove it without jeopardizing any of the other coding.

(click to show/hide)

[State -1, Null]
type = Null
triggerall = !helper(10003),var(37)
triggerall = movehit=1 ;|| (stateno=[1001,1002]) && time<2
triggerall = p2stateno!=5120   
triggerall = var(59) >6
triggerall = var(59)=1
triggerall = random <45*var(59) || var(31)>0
triggerall = var(31)=0 || var(31)=[1,16]
trigger1= (anim=210||anim=410||anim=240) && (var(31)=0&& p2statetype!=A ) 
trigger1 =var(31):=1
trigger1 =var(34):=211
trigger2= (anim=211) && (var(31)=8)
trigger2 =var(31):=9
trigger2 =var(34):=220
trigger3= (stateno=220) && (var(31)=9)
trigger3 =var(31):=10
trigger3 =var(34):=1010
trigger4= (stateno=1010) && (var(31)=10)
trigger4 =var(31):=11
trigger4 =var(34):=200
trigger5= (stateno=211) && (var(31)=1||var(31)=0) && p2statetype!=A
trigger5 =var(31):=2
trigger5 =var(34):=400
trigger6= (anim=201) && (var(31)=11||var(31)=7)
trigger6 =var(31):=ifelse(var(31)=11,12,8)
trigger6 =var(34):=ifelse(var(31)=12,240,210)
trigger7= (stateno=240) && (var(31)=12)
trigger7 =var(31):=13
trigger7 =var(34):=420
trigger8= (anim=400) && (var(31)=2)
trigger8 =var(31):=3
trigger8 =var(34):=410
trigger9= (anim=410) && (var(31)=3)
trigger9 =var(31):=4
trigger9 =var(34):=420
trigger10= (anim=420) && (var(31)=4||var(31)=13)
trigger10 =var(31):=ifelse(var(31)=13,14,5)
trigger10 =var(34):=610
trigger10 = var(30):=1
trigger11= (anim=615) && (var(31)=5||var(31)=14)
trigger11 =var(31):=ifelse(var(31)=14,15,6)
trigger11 =var(34):=ifelse(var(31)=15,620,650)
trigger11 = var(30):=0
trigger12= (stateno=620) && (var(31)=15)
trigger12 =var(31):=16
trigger12 =var(34):=195
trigger13= (stateno=650) && (var(31)=6)
trigger13 =var(31):=7
trigger13 =var(34):=200
trigger14= (stateno=195) && (var(31)=16)
trigger14 =var(31):=0
trigger14 =var(34):=0
ignorehitpause=1

;lvl2
[State -1, Null]
type = Null
triggerall = !helper(10003),var(37)
triggerall = movehit=1 ;|| (stateno=[1001,1002]) && time<2
triggerall = p2stateno!=5120   
triggerall = var(59) >6
triggerall = var(59)=[2,3]
triggerall = random <45*var(59) || var(31)>0
triggerall = var(31)=0 || var(31)=[20,40]
trigger1= (anim=210||anim=410||stateno=240) && (var(31)=0&& p2statetype!=A ) 
trigger1 =var(31):=20
trigger1 =var(34):=420
trigger2= (stateno=250) && (var(31)=32)
trigger2 =var(31):=33
trigger2 =var(34):=1120
trigger3= (stateno=220) && (var(31)=28)
trigger3 =var(31):=29
trigger3 =var(34):=1010
trigger4= (stateno=1010) && (var(31)=29)
trigger4 =var(31):=30
trigger4 =var(34):=200
trigger5= (anim=211) && (var(31)=27)
trigger5 =var(31):=28
trigger5 =var(34):=220
trigger6= (anim=201) && (var(31)=23||var(31)=30||var(31)=35)
trigger6 =var(31):=ifelse(var(31)=35,36,ifelse(var(31)=30,31,24))
trigger6 =var(34):=ifelse(var(31)=36,420,ifelse(var(31)=27,210,240))
trigger7= (stateno=240) && (var(31)=24||var(31)=31)
trigger7 =var(31):=ifelse(var(31)=31,32,25)
trigger7 =var(34):=ifelse(var(31)=25,1000,250)
trigger8= (stateno=1120) && (var(31)=33)
trigger8 =var(31):=34
trigger8 =var(34):=1020
trigger9= (stateno=1020) && (var(31)=34)
trigger9 =var(31):=35
trigger9 =var(34):=200
trigger10= (anim=420) && (var(31)=20||var(31)=36)
trigger10 =var(31):=ifelse(var(31)=36,37,21)
trigger10 =var(34):=610
trigger10 = var(30):=1
trigger11= (anim=[616,617]) && (var(31)=21||var(31)=37)
trigger11 =var(31):=ifelse(var(31)=37,38,22)
trigger11 =var(34):=ifelse(var(31)=38,620,650)
trigger11 = var(30):=0
trigger12= (stateno=620) && (var(31)=38)
trigger12 =var(31):=39
trigger12 =var(34):=195
trigger13= (stateno=650) && (var(31)=22)
trigger13 =var(31):=23
trigger13 =var(34):=200
trigger14= (stateno=195) && (var(31)=39)
trigger14 =var(31):=0
trigger14 =var(34):=0
trigger15= (stateno=1000) && (var(31)=25)
trigger15 =var(31):=26
trigger15 =var(34):=200
trigger16= (stateno=200) && (var(31)=26)
trigger16 =var(31):=27
trigger16 =var(34):=210
ignorehitpause=1

Like I said, if I just delete the whole section of code, his ai doesn't takeover, but has graphical issues such as, his "Level" bar text is misplaced, and his bat for his bat special sprites get distorted and split up. I'm not sure why graphical issues would be linked to his cmd file, but as I said, these things don't happen if I leave the coding as is. It's strange.

[Cyanide]

I don't know what all that does. I can tell you that it's rather stupid

triggerall = var(59) >6
triggerall = var(59)=1
Those are mutually exclusive. var(59) can't be 1 AND greater than 6. Good thing it's a null and all those triggers get evaluated regardless of the triggeralls being correct.

I am guessing that most of those vars help with the rest of the AI. The := bit is an assignment and you can use it to set a variable within a line of code without a varset.

Find out where var(59) is being turned on and how. That's just AI code, it's not the activation method.

[Playing Enemy]

The "triggerall = var(59) >6" line is there because it's supposed to be "triggerall = AILevel >6", as it was before I edited all the AILevel code to be var(59). The "triggerall = var(59)=1" line right after it is supposed to be like that though, cause I didn't edit that part, just the line before it.
I did go through all his coding and found this in his system.cns file. I believe this is how var(59) is being activated.

(click to show/hide)

[State 59, VarSet]
type = VarSet
trigger1 =roundstate!=2 && var(59)=0
v = 59
value = 1

I also remember reading somewhere that auto ai can be linked to triggers/coding that is present in each state of the character, such as this right here...but I could be totally wrong about that as well.

(click to show/hide)

[Statedef 211]
type    = S
movetype= A
physics = S
juggle  =0; 4
poweradd= 30
ctrl = 0
velset = 0,0
anim = ifelse(var(59)>3,302,ifelse((var(59)=[2,3]),301,300))
sprpriority =5

or this section, which is located in the same attacks state coding as the code right above this.

(click to show/hide)

[State 0, VarSet]
type = VarSet
triggerall = AIlevel>0
triggerall = anim=302
triggerall = var(31)=0 && random<45*AIlevel || var(31)>0
trigger1 = animelem=10  || movecontact
v = 27
value = 1

Just with all the AIlevel's being switched to var(59), so it looks like this

(click to show/hide)

[State 0, VarSet]
type = VarSet
triggerall = var(59)>0
triggerall = anim=302
triggerall = var(31)=0 && random<45*var(59) || var(31)>0
trigger1 = animelem=10  || movecontact
v = 27
value = 1

I'm not sure, but these 2 sections of code seem to be dependent to the original Null code I posted, and this is what all his states coding looks like as well. Not sure what I should do, and sorry if I'm confusing anyone.

[Cyanide]

[State 59, VarSet]
type = VarSet
trigger1 =roundstate!=2 && var(59)=0
v = 59
value = 1

Well, that's turning the AI on. All the rest are just AI checks and things to make stuff work. The reason the above is automatic, is because it happens the second the fight starts. 1.0 code uses AIlevel to find out if AI should be on, using AIlevel > 0 or whatever is a perfectly good way to turn on an AI var because it identifies the player is not a human. You need to actually use AI activation methods if you're sticking with winmugen.

So, change the above triggers and make yourself about 30 AI only commands. Simplest method.

[Playing Enemy]

Alright, thanks for the response on this. I apologize, but I'm still a little confused. I know exactly how to add 30 or so AI only commands, and change how var(59) activates, but is this the trigger you were referring to that I should change? This one from the var(59) activation code...

trigger1 =roundstate!=2 && var(59)=0

or these ones, from the "Null" sections...? Since we know they are in conflict with one another, makes sense.

triggerall = var(59) >6
triggerall = var(59)=1

Or is it all 3 that need to be changed?
As far as the 30 AI only commands, this is what I am going to try replacing his original var(59) activation code with. Is it okay if this is posted in his cns file like his original var(59) coding currently is located at? I only ask cause I usual see an AI activation code in the characters CMD file, not the CNS, so it's throwing me off a little.

(click to show/hide)

[State -1, AIActivate]
type = VarSet
triggerall = RoundState != 2
trigger1  = command = "CPU1"
trigger2  = command = "CPU2"
trigger3  = command = "CPU3"
trigger4  = command = "CPU4"
trigger5  = command = "CPU5"
trigger6  = command = "CPU6"
trigger7  = command = "CPU7"
trigger8  = command = "CPU8"
trigger9  = command = "CPU9"
trigger10  = command = "CPU10"
trigger11  = command = "CPU11"
trigger12  = command = "CPU12"
trigger13  = command = "CPU13"
trigger14  = command = "CPU14"
trigger15  = command = "CPU15"
trigger16  = command = "CPU16"
trigger17  = command = "CPU17"
trigger18  = command = "CPU18"
trigger19  = command = "CPU19"
trigger20  = command = "CPU20"
trigger21  = command = "CPU21"
trigger22  = command = "CPU22"
trigger23  = command = "CPU23"
trigger24  = command = "CPU24"
trigger25  = command = "CPU25"
trigger26  = command = "CPU26"
trigger27  = command = "CPU27"
trigger28  = command = "CPU28"
trigger29  = command = "CPU29"
trigger30  = command = "CPU30"
var(59) = 1

[Cyanide]

Almost. But do it when roundstate = 2 rather than != 2. Like i say, fine for AIlevel. But those commands are all entered during the fight. So that means roundstate 2

The other method is activating at 0, prefight state 5900 and 1, intros. Yours because you are using ye olde horrible method has to happen during 2, fight.

[Playing Enemy]

@Cyanide
Sorry for not responding for a few weeks, I was trying to complete the last thing you said to try, but wasn't able to figure it out. AI is totally new to me and kind of confusing at least as far as Frank West goes, and I couldn't make the best sense out of what you were explaining to do in you last post. I asked Kamekaze about it though, since he is the one who coded the character, and he said it would only be possible to fix what I'm trying to fix if I completely recoded the character from scratch. Sounds insane, but I don't know enough to dispute it.

Another issue I'm having with a different character though is, I've converted everything that needs converting including sff to winmugen sff, and recoding everything that needs to be changed for winmugen, but when I go to load the character, they crash winmugen, and just give an error that says, "Can't Access Data, Error in ABC.CNS, Error loading p1". I pasted KFM's constants file and had the character use that for their cns, and they will now load in winmugen, so I can safely say the problem is something to do with the constants. Does anyone have any idea what type of thing in the constants could lead to this type of error message? I'd just use KFM's since it's working, but the character uses different values, so it wouldn't be correct or accurate, even if it's allowing the character to load.

[Cyanide]

Look at KFM's constants. Look at the originals. Compare. Where possible use the originals. Where not possible, that's a new 1.0 constant and you won't be able to do anything.

Also. Oh, Kame's AI. Yeah, you're not really changing that without a lot of work. You'd be better served trashing it and doing a basic AI of your own.

[Playing Enemy]

Okay, I'll do that with KFM like you suggested. A friend of mine said something similarm and it made sense as well.
As for Frank West, I don't really have the confidence in myself yet to code all new AI from scratch. Would it just be possible to remove just the AI all together without effecting anything else? I'm really only trying to be able to play as him, not against him, even though it'd be nice. I'm not one of those guys that cares for watch mode either, and just like to play myself. This is what Kamekaze said to me about Frank West though before you answer.

(click to show/hide)

That was done on purpose (referring to var(59) activation method I believe -Shulbocka), he cannot use any var in the 50s because it screws up all his weapons. The level system and his colors need to stay the same between rounds and in some cases matches. He won't work on win also because the hit stun values are bugged in win mugen. Basically it's pretty hopeless unless you code him again from scratch.  Var59 is used almost in every move he has as well as 58 57 56 and 55. The other 50s control his colors which winmugen only supports 12. Not to mention his super bg on level 3 only changes color because it's a 1.0 only .sff. so yeah porting him is not worth it in any way.  Sorry m8
Also his ai depends on actual levels of ai being a thing.

The part about the sff and pals/colors isn't an issue though, as I've worked through everything except for the AI takeover.

[Cyanide]

Sorry, i think at this point i'd need to download the character and i genuinely hate doing that.

[Playing Enemy]

I don't blame you, and it's all good. It's too bad, at least for me, but it is what it is. I still pmed him to you though, just in case. None the less, thanks for helping me get this far with him. It's good to learn new things whether they lead to victory or not.